-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle more parsing cases (int and str formats, additional props: fix #10, #11 and #13) #12
Merged
+237
−54
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ff87a53
Add the `"enum"` int-format
smondet 0851948
Add `"field-mask"` format
smondet e795852
Make `"additionalProperties"` “boolable”
smondet 8c9edad
Add the `"bytes"` str-format
smondet b35ddbd
Handle empty objects
smondet ce6759d
Add options `--skip-doc` and `--protect-against-duplicates`
smondet 51a30ed
Add option `--only-matching` to limit output
smondet 42755ed
Add missing types (a.k.a. `json`) as comments
smondet abd931e
Add option `--avoid-dangling-refs`
smondet dcf1757
Add option `--json-ocaml-type Module:type`
smondet ed9925e
Make `from` Vs `module` keyword also parametrizable
smondet e93bb6b
Update lib/generator.ml
smondet 2dfb183
Remove more `Printf` module paths
smondet c5822da
Make generated comment more useful
smondet 174a1e6
Update tests
smondet bf3888a
Update README and changelog
smondet 869a612
Merge branch 'master' into smondet-I10-enum-int-format
ixzzd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Add option
--avoid-dangling-refs
commit abd931ee0b62551e8d825c910369ac6142ab63fe
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thinking this is a nice addition, thank you @smondet
Could you please add also tests for this one and mention it in the doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know whether I added enough tests :)