Skip to content

Commit

Permalink
Merge pull request etcd-io#17204 from rahulbapumore/branch1
Browse files Browse the repository at this point in the history
mvcc: Printing etcd backend database related metrics inside scheduleCompaction function
  • Loading branch information
ahrtr authored Jan 15, 2024
2 parents fbcfd4e + 21bbc82 commit 4bc55e5
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions server/storage/mvcc/kvstore_compaction.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"fmt"
"time"

humanize "github.com/dustin/go-humanize"
"go.uber.org/zap"

"go.etcd.io/etcd/server/v3/storage/schema"
Expand Down Expand Up @@ -66,11 +67,16 @@ func (s *store) scheduleCompaction(compactMainRev, prevCompactRev int64) (KeyVal
tx.Unlock()
// gofail: var compactAfterSetFinishedCompact struct{}
hash := h.Hash()
size, sizeInUse := s.b.Size(), s.b.SizeInUse()
s.lg.Info(
"finished scheduled compaction",
zap.Int64("compact-revision", compactMainRev),
zap.Duration("took", time.Since(totalStart)),
zap.Uint32("hash", hash.Hash),
zap.Int64("current-db-size-bytes", size),
zap.String("current-db-size", humanize.Bytes(uint64(size))),
zap.Int64("current-db-size-in-use-bytes", sizeInUse),
zap.String("current-db-size-in-use", humanize.Bytes(uint64(sizeInUse))),
)
return hash, nil
}
Expand Down

0 comments on commit 4bc55e5

Please sign in to comment.