-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename llm-tool-functions to llm-tool, fixes to elisp-to-tool #141
+184
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix #138.
danielkrizian
added a commit
to danielkrizian/llm
that referenced
this pull request
Feb 9, 2025
extends ahyatt#141 to utilities/elisp-to-tool.el
This was referenced Feb 9, 2025
ahyatt
pushed a commit
that referenced
this pull request
Feb 11, 2025
extends #141 to utilities/elisp-to-tool.el Without this fix, ```elisp (require 'utilities/elisp-to-tool) ``` throws `Debugger entered--Lisp error: (void-function llm-make-tool-function)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, make
llm-make-tool
accept arbitrary extra arguments, so no errors are thrown when getting cross-compatibility withgptel
andllm
tools.This also will put out release 0.22.0. We need a new major version since there's an incompatible change (the renaming of a function).