-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #106: improve exception handling in fertiscan
#199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-allagbe
force-pushed
the
106-improve-exception-handling
branch
2 times, most recently
from
October 11, 2024 14:47
28ac44a
to
f13b3bc
Compare
k-allagbe
force-pushed
the
106-improve-exception-handling
branch
from
October 11, 2024 21:29
f13b3bc
to
98354ad
Compare
k-allagbe
force-pushed
the
106-improve-exception-handling
branch
from
October 11, 2024 21:43
d943f6e
to
f14f276
Compare
k-allagbe
force-pushed
the
106-improve-exception-handling
branch
from
October 11, 2024 22:24
c9f882e
to
0903c45
Compare
k-allagbe
force-pushed
the
106-improve-exception-handling
branch
from
October 17, 2024 03:14
70ca3e9
to
561b54d
Compare
k-allagbe
force-pushed
the
106-improve-exception-handling
branch
from
October 17, 2024 04:33
561b54d
to
bdb058f
Compare
Francois-Werbrouck
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a fresh review, I think the error file will help maintain the project in the long run!
This issue will not fix #108 as that is core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The code using a decorator:
is equivalent to:
Note that
LabelInformationNotFoundError
is aQueryError
.