69 retrieve pictures and inferences for a given folder #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and-inferences-for-a-given-folder
…handle-multiple-project' into 69-Retrieve-pictures-and-inferences-for-a-given-folder
3 tasks
|
@Francois-Werbrouck I wait for #76 and #87 to finish this but if you want to take a look when you have time :) |
|
I will take a second look at this once #87 is merged, however it looks good so far after a quick check |
…and-inferences-for-a-given-folder
| raise GetPictureError( | ||
| f"Error: could not check if the picture {picture_id} has an existing inference") | ||
|
|
||
| def get_picture_inference(cursor, picture_id: str): |
There was a problem hiding this comment.
I'd put this in the inference module since we are fetching inference data.
I'd also call it something more relevant because just from the name of the function I was quite confused.
There was a problem hiding this comment.
I'd look into using Pydantic to rebuild the Inference. (and verify its structure in the future)
Francois-Werbrouck
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #69