-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #13, Update Server Configuration #14
Conversation
bin/postgres.sh
Outdated
docker start louis-db-server | ||
elif [ "$STATUS" != "running" ]; then | ||
# check PGPASWORD before using it | ||
echo container does not exist, creating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update here today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more details in your string, including container name
I've introduced a verification function in the last commit (74d69c4) called |
I've applied modification on the verification function in the last commit (0ce5846), now you can utilize the function to validate all environment variables before their usage, if any of them are undefined or empty, the execution will stop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add usage information to the README.md in bin/
bin/postgres.sh
Outdated
docker start louis-db-server | ||
elif [ "$STATUS" != "running" ]; then | ||
# check PGPASWORD before using it | ||
echo container does not exist, creating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more details in your string, including container name
bin/postgres.sh
Outdated
elif [ "$STATUS" != "running" ]; then | ||
echo container does not exist, creating | ||
docker run --name louis-db-server \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be using your environment variable...
In the last commit (8ba5038), I have replace existing variable names with environment variables. This update enhances the flexibility by allowing configuration settings to be managed externally through environment variables, making it easier to adapt to different deployment environments. |
We observed that the code exhibited a high degree of specificity towards |
Fixes #13,