Issue #79, Testing Current Score #84
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
rngadam
suggested changes
Mar 21, 2024
| """ | ||
|
|
||
| cursor.execute(query) | ||
| return cursor.fetchall() |
There was a problem hiding this comment.
(this should be validated by the repo standards check)
| WITH random_crawl AS ( | ||
| SELECT id | ||
| FROM crawl | ||
| ORDER BY |
There was a problem hiding this comment.
this came up before; ordering randomly the table is expensive means you are fetching every row and then picking up one.
it's cheaper to pick a row between 1 and count(*) and use that with OFFSET combined with LIMIT:
There was a problem hiding this comment.
Yes you told me about that, when I copy paste the query I forgot to change ORDER by OFFSET. It will be changed soon.
https://github.com/ai-cfia/.github/blob/main/profile/CONTRIBUTING.md
|
|
Yes sorry, I forgot to put it as draft, I'm working on different PR at the same time for testing purpose, so everything is probably going to change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #79
Test our schema scoring to see if they are here/accurate.
Schema tested: Louis_v005
Test our score weights
Evaluation Criteria
Similarity: ?
Recency: Compare dates and scores to ensure alignment.
Traffic: ?
Current: Confirm that archived documents receive a score of 0.
Typicality: Compare the average number of site references within the dataset and verify if documents with more references receive higher scores.