Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue#16 #56

Closed
wants to merge 2 commits into from
Closed

Fixed Issue#16 #56

wants to merge 2 commits into from

Conversation

JasonPang-ETS
Copy link

@JasonPang-ETS JasonPang-ETS commented Dec 6, 2023

Issue:

Cause:

Initial query from Home.tsx was not stored in variable searchQuery of searchBar.tsx.
Therefore, the value of the search bar would default to empty upon loading SearchPage.tsx.

Solution:

Use setSearchQuery(term) in the useEffect() of searchBar.tsx.

Tests:

  • Manual test using the site debug search prompts
  • Manual test with random search prompts

@rngadam rngadam requested a review from CFIALeronB December 9, 2023 12:59
@k-allagbe
Copy link
Member

Solved in #61

@k-allagbe k-allagbe closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants