Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #71: Fixing the markdown check and repo standard workflow #72

Conversation

ThomasCardin
Copy link
Member

@ThomasCardin ThomasCardin commented Jan 17, 2024

@ThomasCardin ThomasCardin requested a review from rngadam January 17, 2024 15:25
@ThomasCardin ThomasCardin self-assigned this Jan 17, 2024
@ThomasCardin ThomasCardin changed the title isse #71: changed secrets for branch protection inside repo standard issue #71: changed secrets for branch protection inside repo standard Jan 17, 2024
@rngadam
Copy link
Contributor

rngadam commented Jan 17, 2024

@ThomasCardin net result from the commits seems to be no changes?

image

@ThomasCardin
Copy link
Member Author

ThomasCardin commented Jan 24, 2024

@ThomasCardin net result from the commits seems to be no changes?

image

Yes, indeed, but the pull request remains relevant as there are currently errors with the workflows. See ai-cfia/finesse-backend#33 (comment)

@ThomasCardin ThomasCardin changed the title issue #71: changed secrets for branch protection inside repo standard issue #71: Fixing the markdown check and repo standard workflow Jan 25, 2024
@ThomasCardin
Copy link
Member Author

@rngadam The workflows are now fixed. As you can see here: ai-cfia/nachet-backend#49. If possible, please review as soon as possible to avoid changing the branch reference in all workflows. I would like to keep it as @main.

@ThomasCardin ThomasCardin merged commit 2f5997d into main Jan 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix every workflow inside this repository and make sure nachet, finesse and infra have the right workflow
2 participants