-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #36: Create DNS zone for inspection.alpha.canada.ca #46
issue #36: Create DNS zone for inspection.alpha.canada.ca #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Make sure when filling the variable for soa_record_tech_contact_email = var.soa_record_tech_contact_email that you replace '@' with a dot in the email address.
You can look up how emails are written up in SOA : https://docs.rackspace.com/docs/what-is-an-soa-record
I'm pretty sure it's possible to use an @ to define an email address in a SOA. Based on this Request for Comments (RFC), the RNAME mentions the use of a For more information related to the article I just mentioned: https://www.ietf.org/standards/ |
…ha-canada-ca-with-Terraform
This pull request will allow us to manage the DNS
inspection.alpha.canada.ca
within Azure. This resource will be delegated to the parent, which can be found in this repository. Here is an example with Google Cloud https://github.com/cds-snc/dns/blob/main/terraform/phac-aspc.alpha.canada.ca.tfOnce this pull request is approved, a pull request will be created on the repository mentioned above to perform the delegation.
Also, I renamed every
versions.tf
forproviders.tf
. See https://developer.hashicorp.com/terraform/language/providers/configuration#alias-multiple-provider-configurations.