Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #36: Create DNS zone for inspection.alpha.canada.ca #46

Merged
merged 14 commits into from
Feb 19, 2024

Conversation

ThomasCardin
Copy link
Member

@ThomasCardin ThomasCardin commented Feb 15, 2024

This pull request will allow us to manage the DNS inspection.alpha.canada.ca within Azure. This resource will be delegated to the parent, which can be found in this repository. Here is an example with Google Cloud https://github.com/cds-snc/dns/blob/main/terraform/phac-aspc.alpha.canada.ca.tf

Once this pull request is approved, a pull request will be created on the repository mentioned above to perform the delegation.

Also, I renamed every versions.tf for providers.tf. See https://developer.hashicorp.com/terraform/language/providers/configuration#alias-multiple-provider-configurations.

@ThomasCardin ThomasCardin changed the title issue #36: created DNS zone for inspection.alpha.canada.ca issue #36: Create DNS zone for inspection.alpha.canada.ca Feb 15, 2024
@ThomasCardin ThomasCardin requested a review from rngadam February 15, 2024 20:11
@ThomasCardin ThomasCardin marked this pull request as draft February 15, 2024 21:21
@ThomasCardin ThomasCardin marked this pull request as ready for review February 16, 2024 16:56
Copy link
Contributor

@SonOfLope SonOfLope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Make sure when filling the variable for soa_record_tech_contact_email = var.soa_record_tech_contact_email that you replace '@' with a dot in the email address.

You can look up how emails are written up in SOA : https://docs.rackspace.com/docs/what-is-an-soa-record

@ThomasCardin
Copy link
Member Author

LGTM!

Make sure when filling the variable for soa_record_tech_contact_email = var.soa_record_tech_contact_email that you replace '@' with a dot in the email address.

You can look up how emails are written up in SOA : https://docs.rackspace.com/docs/what-is-an-soa-record

I'm pretty sure it's possible to use an @ to define an email address in a SOA. Based on this Request for Comments (RFC), the RNAME mentions the use of a <domain-name> to specify the person responsible for this zone.

For more information related to the article I just mentioned: https://www.ietf.org/standards/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants