112 improve exception handling #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Hi @Francois-Werbrouck and @ChromaticPanic here's a PR to improve exception handling on the backend. What do you think needs to be added? I think I'll also create the same issue for the datastore to check if all nachet functions and requests handle relevant exceptions. |
ChromaticPanic
approved these changes
Aug 6, 2024
| print(error) | ||
| return jsonify([f"GetUserIdError: {str(error)}"]), 400 | ||
| return jsonify([f"Datastore Error retrieving user id for email {email} : {str(error)}"]), 400 |
There was a problem hiding this comment.
Should we make this a different return code?
There was a problem hiding this comment.
I don't know if it's relevant to use different codes, it depends on the frontend I think, what do you think @ChromaticPanic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #112