Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #126: updates imports/dependencies with new monorepo modules structure #127

Conversation

SonOfLope
Copy link
Contributor

ref #126

@SonOfLope SonOfLope requested a review from k-allagbe October 8, 2024 18:17
@SonOfLope SonOfLope requested a review from a team as a code owner October 8, 2024 18:17
@SonOfLope SonOfLope marked this pull request as draft October 8, 2024 18:33
@SonOfLope SonOfLope marked this pull request as ready for review October 8, 2024 20:51
@SonOfLope SonOfLope requested a review from a team as a code owner October 8, 2024 21:12
@@ -10,4 +10,4 @@ cryptography
pyyaml
pydantic
python-magic
nachet-datastore @git+https://github.com/ai-cfia/ailab-datastore.git@main
nachet-datastore @git+https://github.com/ai-cfia/ailab-datastore.git@v1.0.0-nachet-datastore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so I understand correctly, This point to a release on the Datastore related to Nachet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. it points to the following release :
https://github.com/ai-cfia/ailab-datastore/releases/tag/v1.0.0-nachet-datastore
It only contains files dedicated to nachet. This PR is simply to fix currently workflow since the changes from datastore prevent current main branch from working. Once we validate that it works locally and we merge this, I will work on documenting the process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification! 🥇

Francois-Werbrouck

This comment was marked as spam.

Copy link
Contributor

@Francois-Werbrouck Francois-Werbrouck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SonOfLope SonOfLope requested review from Francois-Werbrouck and a team October 8, 2024 21:58
@SonOfLope SonOfLope merged commit 78fd8bc into main Oct 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update nachet-backend requirements.txt to point to a release version (example v0.1.0)
2 participants