Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #57: Implement image validation in backend #58

Merged
merged 24 commits into from
Apr 10, 2024
Merged

issue #57: Implement image validation in backend #58

merged 24 commits into from
Apr 10, 2024

Conversation

MaxenceGui
Copy link

@MaxenceGui MaxenceGui commented Feb 20, 2024 •
edited
Loading

Tasks

  • Add an image validation function in the backend
  • Implement extension validation check
  • Implement resizable validation check
  • Implement size validation check
  • Implement file header validation check

@MaxenceGui MaxenceGui added this to the M1 (2024 February) milestone Feb 20, 2024
@MaxenceGui MaxenceGui self-assigned this Feb 20, 2024
@MaxenceGui MaxenceGui linked an issue Feb 20, 2024 that may be closed by this pull request
Implement image validation in backend #57
Closed
5 tasks
@rngadam rngadam mentioned this pull request Mar 19, 2024
Closed
@MaxenceGui MaxenceGui marked this pull request as ready for review March 20, 2024 20:34
@MaxenceGui MaxenceGui requested review from a team, rngadam and RussellJimmies March 20, 2024 20:34
ibrahim-kabir
ibrahim-kabir reviewed Mar 21, 2024
View reviewed changes
app.py Outdated Show resolved Hide resolved
Maxence Guindon and others added 2 commits March 21, 2024 09:58
k-allagbe
k-allagbe reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@k-allagbe k-allagbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just optional considerations if even relevent.

app.py Outdated Show resolved Hide resolved
app.py Show resolved Hide resolved
@MaxenceGui MaxenceGui requested a review from k-allagbe March 26, 2024 13:06
@MaxenceGui
Copy link
Author

MaxenceGui commented Mar 26, 2024 •
edited
Loading

Just optional considerations if even relevent.

Your comments are always relevant and welcome

@MaxenceGui MaxenceGui removed this from the M2 (2024 March) milestone Mar 27, 2024
RussellJimmies
RussellJimmies reviewed Mar 28, 2024
View reviewed changes
app.py Outdated Show resolved Hide resolved
rngadam
rngadam suggested changes Apr 2, 2024
View reviewed changes
app.py Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
@MaxenceGui MaxenceGui requested a review from rngadam April 3, 2024 14:25
@rngadam
Copy link

rngadam commented Apr 5, 2024

image

revisit environment variables to set reasonable defaults when a variable is not set.

@MaxenceGui
Copy link
Author

image

revisit environment variables to set reasonable defaults when a variable is not set.

Done

rngadam
rngadam suggested changes Apr 5, 2024
View reviewed changes
Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, just one tweak on the new size variable

app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
rngadam
rngadam suggested changes Apr 5, 2024
View reviewed changes
tests/test_image_validation.py Outdated Show resolved Hide resolved
@MaxenceGui MaxenceGui requested a review from a team as a code owner April 8, 2024 15:43
@MaxenceGui MaxenceGui requested a review from rngadam April 8, 2024 15:44
@RussellJimmies RussellJimmies self-requested a review April 9, 2024 20:36
@rngadam rngadam self-requested a review April 10, 2024 12:52
rngadam
rngadam suggested changes Apr 10, 2024
View reviewed changes
Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased

@MaxenceGui
Copy link
Author

Needs to be rebased

Rebase done

rngadam
rngadam suggested changes Apr 10, 2024
View reviewed changes
Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix linting error

app.py Show resolved Hide resolved
rngadam
rngadam reviewed Apr 10, 2024
View reviewed changes
app.py Show resolved Hide resolved
@MaxenceGui MaxenceGui mentioned this pull request Apr 10, 2024
Closed
3 tasks
@MaxenceGui MaxenceGui merged commit 918cd38 into main Apr 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-allagbe k-allagbe k-allagbe approved these changes

@ibrahim-kabir ibrahim-kabir ibrahim-kabir approved these changes

@RussellJimmies RussellJimmies RussellJimmies approved these changes

@rngadam rngadam rngadam approved these changes

Assignees

@MaxenceGui MaxenceGui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement image validation in backend
5 participants
@MaxenceGui @rngadam @RussellJimmies @ibrahim-kabir @k-allagbe