Fixes #76: Enhance Data Storage: Including Model Details in the result.json file #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxenceGui
commented
Apr 15, 2024
MaxenceGui
commented
- Add the models key to the result store in the blob storage
MaxenceGui
changed the title
| @@ -455,6 +458,7 @@ async def test(): | |||
| m = Model( | |||
| request_function["test"], | |||
| "test_model1", | |||
| 1, | |||
There was a problem hiding this comment.
Model() took different data and in third position, they took the version of the model. Here, since I'm building a test model for the testing, I set the version of the test model to 1.
In the test refactor issue (#59) we should probably delete this endpoint and build the test models in the test files directly.
amirardalan9473
approved these changes
Apr 22, 2024
k-allagbe
reviewed
Apr 23, 2024
k-allagbe
approved these changes
Apr 23, 2024
Markdown failed checkDead link because hugging face is down
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.