Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

158 Negative Feedback #159

Merged
merged 5 commits into from
Jun 5, 2024
Merged

158 Negative Feedback #159

merged 5 commits into from
Jun 5, 2024

Conversation

ChromaticPanic
Copy link
Contributor

@ChromaticPanic ChromaticPanic commented May 30, 2024

Closes #158
Related #129
Related #40

Copy link
Contributor

@Francois-Werbrouck Francois-Werbrouck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont get what the classId is? What is it representing?

Copy link
Contributor Author

@ChromaticPanic ChromaticPanic Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just gave it a generic name. it would be the species id/uuid . In image classification, the label is the class. For Nachet the classes are species names, but this interface can technically be used for any image classification project.

@ChromaticPanic ChromaticPanic changed the base branch from 156-Positive-Feedback to main June 5, 2024 13:27
@ChromaticPanic ChromaticPanic force-pushed the 158-Negative-Feedback branch from 6e56ae2 to b13112f Compare June 5, 2024 13:31
@ChromaticPanic ChromaticPanic merged commit 9074593 into main Jun 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide negative feedback with a correction to the inference box position and dimensions
3 participants