Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackendEngine: Added bookkeeping of custom_params of each backend to … #16

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

mkhazraee
Copy link
Contributor

…the base class.

  • The backend plugin should not modify the passed parameters by the user, so the base class bookkeeps them and gives setter and getter methods to the plugin to access it.
  • Now plugin can ask for value of a key, or add key/values for default parameters.
  • Also added an API on the base class to return all the key/values, to be used in the agent API.
  • Some rearragements in the base backend class to use protected when appropriate. Also the agent name is set only during construction and cannot be modified later.

…the base class.

* The backend plugin should not modify the passed parameters by the user, so the base
  class bookkeeps them and gives setter and getter methods to the plugin to access it.
* Now plugin can ask for value of a key, or add key/values for default parameters.
* Also added an API on the base class to return all the key/values, to be used in the
  agent API.
* Some rearragements in the base backend class to use protected when appropriate.
  Also the agent name is set only during construction and cannot be modified later.

Signed-off-by: Moein Khazraee <[email protected]>
Copy link
Contributor

@artpol84 artpol84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@mkhazraee mkhazraee marked this pull request as ready for review March 12, 2025 20:13
@mkhazraee mkhazraee merged commit caef5af into main Mar 12, 2025
6 checks passed
@mkhazraee mkhazraee deleted the mkhazraee/param_api_updates branch March 12, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants