ucx_backend: free canceled requests #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhazraee
approved these changes
Mar 12, 2025
|
@tstamler we need sign-off ? |
Fix to properly free canceled UCX requests. UCX documentation specifies that requests must still be explicitly freed after calling cancel: https://openucx.readthedocs.io/en/master/api.html#_CPPv418ucp_request_cancel12ucp_worker_hPv Signed-off-by: Timothy Stamler <[email protected]>
tstamler
force-pushed
the
tstamler/ucx_cancel_fix
branch
from
eb0c0d1 to
dab08eb
Compare
The initial PR message didn't update, but I've update the commit message with these |
artpol84
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to properly free request handles for in progress requests.