Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mkhazraee/backend api updates #27

Merged
merged 2 commits into from
Mar 14, 2025
Merged

Mkhazraee/backend api updates #27

merged 2 commits into from
Mar 14, 2025

Conversation

mkhazraee
Copy link
Contributor

No description provided.

@mkhazraee mkhazraee changed the base branch from mkhazraee/nixlBlobDesc to main March 14, 2025 06:38
@mkhazraee mkhazraee requested a review from tstamler March 14, 2025 06:42
@mkhazraee mkhazraee marked this pull request as ready for review March 14, 2025 06:43
@mkhazraee mkhazraee closed this Mar 14, 2025
@mkhazraee mkhazraee reopened this Mar 14, 2025
@mkhazraee mkhazraee requested a review from vvenkates27 March 14, 2025 07:30
@mkhazraee mkhazraee force-pushed the mkhazraee/backend_api_updates branch from c6f6f8e to 05027dd Compare March 14, 2025 07:57
@mkhazraee mkhazraee force-pushed the mkhazraee/backend_api_updates branch from 05027dd to 77d92d9 Compare March 14, 2025 08:07
@mkhazraee
BackendEngine API: Added prepXfer and getSupportedMems methods and mo…
6d30f7f 
…dified getNotif

* Also reordered the postXfer function arguments order, and made the notification
  optional parameter.
* For getNotif, propagated the removal of new entry count to the Agent.
* Updated UCX/GDS backends and agent implementations and tests accordingly.

Signed-off-by: Moein Khazraee <[email protected]>
@mkhazraee mkhazraee force-pushed the mkhazraee/backend_api_updates branch from 77d92d9 to 8515d29 Compare March 14, 2025 08:19
@mkhazraee mkhazraee requested review from artpol84 and vvenkates27 and removed request for vvenkates27 March 14, 2025 08:31
tstamler
tstamler reviewed Mar 14, 2025
View reviewed changes
@mkhazraee
Backend API: replaced notif_msg with nixl_opt_b_args_t to be extendib…
273de8c 
…le for future

nixl_opt_b_args_t has a single member for now, notifMsg.

Signed-off-by: Moein Khazraee <[email protected]>
@mkhazraee mkhazraee force-pushed the mkhazraee/backend_api_updates branch from 8515d29 to 273de8c Compare March 14, 2025 18:14
@tstamler tstamler self-requested a review March 14, 2025 18:24
artpol84
artpol84 reviewed Mar 14, 2025
View reviewed changes
Copy link
Contributor

@artpol84 artpol84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this PR has too many irrelevant changes that makes it hard to read the relevant ones.

@mkhazraee mkhazraee merged commit f8e909d into main Mar 14, 2025
6 checks passed
@mkhazraee mkhazraee deleted the mkhazraee/backend_api_updates branch March 14, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artpol84 artpol84 artpol84 approved these changes

@vvenkates27 vvenkates27 vvenkates27 approved these changes

@tstamler tstamler tstamler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkhazraee @artpol84 @vvenkates27 @tstamler