-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Object (MO) UCX backend implementation (rebased over code restructuring PR) #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04b2c0b
to
d345441
Compare
d345441
to
17673e4
Compare
17673e4
to
82dd82e
Compare
82dd82e
to
7b022ac
Compare
tstamler
reviewed
Mar 19, 2025
tstamler
reviewed
Mar 19, 2025
tstamler
reviewed
Mar 19, 2025
tstamler
reviewed
Mar 19, 2025
tstamler
requested changes
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks really good, just need supportsLocal to return false and a few extra comments.
I have updated the PR description and will fix comments shortly |
7b022ac
to
9f00728
Compare
9f00728
to
297bdc7
Compare
Isolate header files from compile-time dependencies (may not be required if global config.h is distributed along with header files) Signed-off-by: Artem Y. Polyakov <[email protected]>
Progress may be required for both ucx1 and ucx2 in different stages Signed-off-by: Artem Y. Polyakov <[email protected]>
297bdc7
to
e3db6f3
Compare
aranadive
reviewed
Mar 19, 2025
tstamler
approved these changes
Mar 19, 2025
aranadive
reviewed
Mar 19, 2025
aranadive
reviewed
Mar 19, 2025
aranadive
reviewed
Mar 19, 2025
aranadive
reviewed
Mar 19, 2025
e3db6f3
to
2c8ba09
Compare
aranadive
reviewed
Mar 19, 2025
mkhazraee
reviewed
Mar 19, 2025
mkhazraee
reviewed
Mar 19, 2025
mkhazraee
reviewed
Mar 19, 2025
mkhazraee
reviewed
Mar 19, 2025
mkhazraee
reviewed
Mar 19, 2025
2c8ba09
to
481b6b2
Compare
mkhazraee
reviewed
Mar 19, 2025
Add new UCX-based backend that allows associating NIXL logical "devices" with different UCX workers. The primary motivation is that UCX v1.18 doesn't support more than one GPGPU per UCX context. NOTE: this is expected to be fixed in UCX v1.19 so this backend might be viewed as a workaround unless other uses will be found. Signed-off-by: Artem Y. Polyakov <[email protected]>
481b6b2
to
23af353
Compare
mkhazraee
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces PR #30 (see unit test outputs there)
Adds new UCX-based backend that allows associating NIXL
logical "devices" with different UCX workers.
The primary motivation is that UCX v1.18 doesn't
support more than one GPGPU per UCX context.
NOTE: this is expected to be fixed in UCX v1.19
so this backend might be viewed as a workaround
unless other uses will be found.
Limitations:
Both limitations will be removed in a follow-up PRs