Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixl/plugins: Fix static plugins and tests #70

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

aranadive
Copy link
Contributor

UCX_MO as a static plugin should be found correctly.
Also, python tests should find UCX and build pip correctly.

@aranadive aranadive force-pushed the aranadive/static_plug_fix branch from 49a3e15 to 6a8a0a4 Compare March 20, 2025 19:28
@aranadive aranadive marked this pull request as ready for review March 20, 2025 19:30
@aranadive aranadive requested a review from karya0 March 20, 2025 19:32
@aranadive aranadive enabled auto-merge (squash) March 20, 2025 19:33
Copy link

@whoisj whoisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Left a question.

@aranadive aranadive disabled auto-merge March 20, 2025 20:33
UCX_MO as a static plugin should be found correctly. Update test_plugin
to use UCX_MO as plugin.

Signed-off-by: Adit Ranadive <[email protected]>
@aranadive aranadive enabled auto-merge (squash) March 20, 2025 20:39
@aranadive aranadive merged commit 49ce61c into main Mar 20, 2025
6 checks passed
@aranadive aranadive deleted the aranadive/static_plug_fix branch March 20, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants