wheel: initial effort to allow dynamic linking of plugins #88
Conversation
tstamler
force-pushed
the
tstamler/python_dynamic_plugins
branch
from
0bd0fb3 to
2a81d63
Compare
src/api/python/__init__.py
Outdated
|
|
||
| __all__ = [nixl] | ||
|
|
||
| plugin_dir = nixl.__file__[:-16] + ".nixl.mesonpy.libs/plugins/" |
There was a problem hiding this comment.
this is the part that gives me anxiety, basically this will find the init.py file. So I'm removing the "nixl/init.py" from the end and then adding ".nixl.mesonpy.libs/plugins/" but I'm not sure if that path will be consistent across systems. open to alternatives
There was a problem hiding this comment.
added an extra check for a different path, might be an ok option
There was a problem hiding this comment.
Shouldnt you check if NIXL_PLUGIN_DIR is not set and then only do this? You may be overwriting a path set by the user.
There was a problem hiding this comment.
good point, I've updated it
Add explicit typing for python API parameters (where appropriate). Remove workarounds to enable fully automatic backend selection for python users. Signed-off-by: Timothy Stamler <[email protected]>
Address comments from PR #86: - Update types - Add return values to API functions - Add backend list option to appropriate functions Signed-off-by: Timothy Stamler <[email protected]>
Signed-off-by: Timothy Stamler <[email protected]>
tstamler
force-pushed
the
tstamler/python_dynamic_plugins
branch
from
cf2b255 to
8b055dd
Compare
|
seems good in testing so far, will test with test.pypi before giving to release team |
tstamler
force-pushed
the
tstamler/python_dynamic_plugins
branch
from
8b055dd to
a4d3ee1
Compare
test/python/nixl_api_test.py
Outdated
| @@ -23,6 +25,10 @@ | |||
| if __name__ == "__main__": | |||
| buf_size = 256 | |||
| # Allocate memory and register with NIXL | |||
|
|
|||
| print("Plugin DIR") | |||
There was a problem hiding this comment.
Using NIXL Plugins from:
Signed-off-by: Timothy Stamler <[email protected]>
tstamler
force-pushed
the
tstamler/python_dynamic_plugins
branch
from
c4ebbcd to
c71c0c4
Compare
This PR removes the need to statically link in plugins to our python module by setting an environment variable in our module init.py. Also removes an old dependency.