Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/reservoir experiments #2363

Draft
wants to merge 46 commits into
base: master
Choose a base branch
from
Draft

Dev/reservoir experiments #2363

wants to merge 46 commits into from

Conversation

AnnaKwa
Copy link
Contributor

@AnnaKwa AnnaKwa commented Nov 3, 2023

Short description of why the PR is needed and how it satisfies those requirements, in sentence form.

(Delete unused sections)
Added public API:

  • symbol (e.g. vcm.my_function) or script and optional description of changes or why they are needed
  • Can group multiple related symbols on a single bullet

Refactored public API:

  • Bulleted list of removed or refactored symbols, such as changes to name, type, behavior, argument, etc. Be cautious about doing these and discuss with team more broadly.

Significant internal changes:

  • Bulleted list of changes to non-public API

Requirement changes:

  • Bulleted list, if relevant, of any changes to setup.py, requirement.txt, environment.yml, etc

  • Ran make lock_deps/lock_pip following these instructions

  • Add PR review with license info for any additions to constraints.txt
    (example)

  • Tests added

Resolves # [JIRA-TAG]

Coverage reports (updated automatically):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants