issue996 #172
issue996 #172
Conversation
| if (initial_landmark_graph_has_cycle_of_natural_orderings) { | ||
| log << "Found a cycle of natural (or stronger) landmark orderings. By " | ||
| << "the definition of natural orderings, the problem is unsolvable." | ||
| << endl; |
There was a problem hiding this comment.
I am not sure I would want to make this output here. I suggest just returning infinity, but possibly including an output along the lines of this in the code that computes the flag. I find output in a "preprocessing" stage more palatable than "inside" the heuristic computation. In general, at least in future code, I'd also always guard output like this with a verbosity test, but I didn't check how we do it with other landmark-related outputs.
There was a problem hiding this comment.
Sure, I'll remove the comment in the heuristic. You write "including an output along the lines of this", so is there something in particular you would change about the output?
There was a problem hiding this comment.
It could be briefer, but I don't feel strongly about this. I might just write something along the lines of "Found a cycle of natural landmark orderings." and nothing more. That the problem is unsolvable as a consequence will be printed anyway by the search algorithm, I think.
There was a problem hiding this comment.
I see, sure, makes sense.
…s before starting search.
ClemensBuechner
force-pushed
the
issue996
branch
from
b13f5db to
5781290
Compare
No description provided.