Add NodeType and RequestUrlCollectorStream to url-collector #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add http event field to store post body * Display post body * Fix clippy warning --------- Co-authored-by: Jungkeun Park <[email protected]>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 33.69% 33.48% -0.21%
==========================================
Files 13 13
Lines 650 654 +4
==========================================
Hits 219 219
- Misses 431 435 +4 ☔ View full report in Codecov by Sentry. |
dayeon5470
force-pushed
the
add_url_collector
branch
2 times, most recently
from
8a6e935
to
3213617
Compare
| @@ -195,15 +195,15 @@ mod tests { | |||
| let nsec = 123; | |||
| let ndt = NaiveDateTime::from_timestamp_opt(sec, nsec).unwrap(); | |||
|
|
|||
| let ts = ndt.timestamp_nanos_opt().unwrap(); | |||
| let ts = ndt.timestamp_nanos(); | |||
dayeon5470
force-pushed
the
add_url_collector
branch
from
3213617
to
826c62f
Compare
marioCluml
approved these changes
Dec 19, 2023
dayeon5470
force-pushed
the
add_url_collector
branch
from
826c62f
to
a4c5997
Compare
sophie-cluml
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87