Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add send/receive url collector stream message and testcode #89

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

dayeon5470
Copy link

@dayeon5470 dayeon5470 commented Dec 22, 2023

Fixes #87

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (72f17ed) 33.48% compared to head (893b6fb) 35.21%.

Files Patch % Lines
src/publish.rs 94.73% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              tis      #89      +/-   ##
==========================================
+ Coverage   33.48%   35.21%   +1.72%     
==========================================
  Files          13       13              
  Lines         654      673      +19     
==========================================
+ Hits          219      237      +18     
- Misses        435      436       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sophie-cluml sophie-cluml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@@ -457,7 +506,7 @@ mod tests {
use crate::frame::send_bytes;
use crate::publish::{
range::ResponseRangeData,
stream::{RequestCrusherStream, RequestHogStream},
stream::{RequestCrusherStream, RequestHogStream, RequestUrlCollectorStream},
Copy link
Contributor

@sophie-cluml sophie-cluml Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tc 👍

src/publish.rs Outdated Show resolved Hide resolved
@sophie-cluml
Copy link
Contributor

가능하시다면 다음 브랜치들은 작업 브랜치명을 tis/xxx 요렇게 해주시면 감사하겠습니다. (현 PR은 이대로 괜찮습니다)

Copy link
Contributor

@sophie-cluml sophie-cluml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sophie-cluml sophie-cluml merged commit bdabae7 into tis Dec 22, 2023
8 checks passed
@sophie-cluml sophie-cluml deleted the url_collector branch December 22, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants