Support command-line interface and update configuration API #796

BLYKIM · 2024-08-09T03:15:55Z

Support command line interface.
- Remove cert, key, root fields from config file.
Change setGigantoConfig to receive toml-formatted string with full configuration.
Update gigantoConfig to respond full configuration.
Rename root to ca_certs.

Closes: #779
Closes: #784
Closes: #785
Closes: #807

src/settings.rs

CHANGELOG.md

src/settings.rs

Cargo.toml

src/settings.rs

src/graphql/status.rs

kimhanbeom · 2024-08-22T08:14:33Z

@BLYKIM There is currently further discussion about whether root should be renamed to root_ca or something else, so this pr should be pending.

src/graphql/status.rs

CHANGELOG.md

README.md

sophie-cluml · 2024-09-03T11:40:14Z

#796 (comment) 에 대하여 #819 이슈가 생성되었습니다.

codecov · 2024-09-04T01:46:42Z

Codecov Report

Attention: Patch coverage is 85.25180% with 41 lines in your changes missing coverage. Please review.

Project coverage is 76.83%. Comparing base (1469d17) to head (c467297).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/main.rs	35.00%	26 Missing ⚠️
src/settings.rs	6.25%	15 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
+ Coverage   76.06%   76.83%   +0.76%     
==========================================
  Files          31       31              
  Lines       24909    24965      +56     
==========================================
+ Hits        18948    19181     +233     
+ Misses       5961     5784     -177

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test code가 필요합니다.

sophie-cluml · 2024-09-04T02:51:32Z

그리고 commit message의 giganto_config는 GraphQL API를 의미하신 것 같은데 맞을까요? 맞다면 gigantoConfig 로 변경 부탁드립니다.

src/settings.rs

sophie-cluml

테스트코드 코멘트만 확인 부탁드립니다. 나머지는 좋아보입니다.

src/graphql/status.rs

sophie-cluml

LGTM

Cargo.toml

sehkone · 2024-09-06T07:55:00Z

CHANGELOG.md

+- Removed `unsafe` block in `write_run_tcpdump` while creating a temporary file.
 - Remove migration code less than `0.15.3`


I think these should be in the section "Removed". What do you think about that?

sehkone · 2024-09-06T07:55:26Z

src/graphql/status.rs

+        self.max_open_files
+    }
+
+    async fn max_mb_of_level_base(&self) -> u64 {


Why don't you use StringNumber?

Or, is this Okay because it is not directly returned?

kimhanbeom · 2024-09-09T01:26:17Z

@BLYKIM
Since the return type of GraphQL server is i32, it does not seem necessary to use StringNumber for types that do not lose precision, such as max_open_files, num_of_thread, and ack_transmission.

- Remove `cert`, `key`, `root` from config file. - Remove default certification path.

BLYKIM requested a review from sophie-cluml August 11, 2024 23:03

sophie-cluml reviewed Aug 12, 2024

View reviewed changes

src/settings.rs Outdated Show resolved Hide resolved

sophie-cluml reviewed Aug 12, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

sophie-cluml reviewed Aug 12, 2024

View reviewed changes

src/settings.rs Outdated Show resolved Hide resolved

sophie-cluml reviewed Aug 12, 2024

View reviewed changes

src/settings.rs Outdated Show resolved Hide resolved

BLYKIM force-pushed the bly/command_line branch 4 times, most recently from fcb6bd3 to 55b608e Compare August 13, 2024 22:35

sophie-cluml reviewed Aug 13, 2024

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

src/settings.rs Outdated Show resolved Hide resolved

BLYKIM force-pushed the bly/command_line branch from 55b608e to 710cfab Compare August 13, 2024 23:38

sophie-cluml reviewed Aug 13, 2024

View reviewed changes

src/settings.rs Outdated Show resolved Hide resolved

src/graphql/status.rs Outdated Show resolved Hide resolved

BLYKIM force-pushed the bly/command_line branch from 710cfab to d9c7020 Compare August 15, 2024 23:09

BLYKIM requested a review from sophie-cluml August 16, 2024 06:56

sophie-cluml reviewed Aug 16, 2024

View reviewed changes

src/graphql/status.rs Outdated Show resolved Hide resolved

BLYKIM force-pushed the bly/command_line branch 3 times, most recently from f23d0ae to cc0c5f1 Compare August 22, 2024 06:44

BLYKIM requested a review from sophie-cluml August 22, 2024 06:45

BLYKIM force-pushed the bly/command_line branch from cc0c5f1 to 20dba02 Compare August 22, 2024 06:49

sophie-cluml reviewed Aug 24, 2024

View reviewed changes

src/graphql/status.rs Show resolved Hide resolved

src/graphql/status.rs Outdated Show resolved Hide resolved

BLYKIM force-pushed the bly/command_line branch 2 times, most recently from 402a536 to 17f42ff Compare August 27, 2024 06:13

BLYKIM requested a review from sophie-cluml August 27, 2024 06:29

sophie-cluml reviewed Aug 28, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

sophie-cluml reviewed Aug 28, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

sophie-cluml reviewed Aug 28, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

BLYKIM force-pushed the bly/command_line branch 2 times, most recently from 8d7630c to feb0331 Compare August 28, 2024 01:53

sophie-cluml mentioned this pull request Sep 3, 2024

Remove unnecessary "Giganto" prefix/infix in configuration related APIs and code #819

Closed

BLYKIM force-pushed the bly/command_line branch from b333e81 to c779eb8 Compare September 4, 2024 01:37

BLYKIM force-pushed the bly/command_line branch from c779eb8 to ed088f9 Compare September 5, 2024 01:15

sophie-cluml reviewed Sep 5, 2024

View reviewed changes

src/settings.rs Outdated Show resolved Hide resolved

BLYKIM force-pushed the bly/command_line branch from ed088f9 to 8b0b83b Compare September 5, 2024 08:30

sophie-cluml reviewed Sep 5, 2024

View reviewed changes

src/graphql/status.rs Show resolved Hide resolved

BLYKIM force-pushed the bly/command_line branch from 8b0b83b to cda491b Compare September 6, 2024 00:59

sophie-cluml approved these changes Sep 6, 2024

View reviewed changes

sehkone reviewed Sep 6, 2024

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

sehkone reviewed Sep 6, 2024

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

BLYKIM force-pushed the bly/command_line branch from cda491b to aadd62a Compare September 6, 2024 07:36

sehkone reviewed Sep 6, 2024

View reviewed changes

BLYKIM force-pushed the bly/command_line branch 3 times, most recently from 5100c39 to 87e34c9 Compare September 9, 2024 00:00

BLYKIM force-pushed the bly/command_line branch from 87e34c9 to 242bbc9 Compare September 9, 2024 01:32

BLYKIM added 3 commits September 10, 2024 11:00

Support command-line interface

9f55045

- Remove `cert`, `key`, `root` from config file. - Remove default certification path.

Change setGigantoConfig api to receive full configuration toml string

a65fcfb

Update gigantoConfig to respond full configuration

c467297

BLYKIM force-pushed the bly/command_line branch from 242bbc9 to c467297 Compare September 10, 2024 02:19

sophie-cluml approved these changes Sep 10, 2024

View reviewed changes

sophie-cluml merged commit 5811c47 into main Sep 10, 2024
10 checks passed

sophie-cluml deleted the bly/command_line branch September 10, 2024 02:36

kimhanbeom mentioned this pull request Sep 10, 2024

Upgrade openssl to avoid a security vulnerability #804

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support command-line interface and update configuration API #796

Support command-line interface and update configuration API #796

BLYKIM commented Aug 9, 2024 •

edited

Loading

kimhanbeom commented Aug 22, 2024 •

edited

Loading

sophie-cluml commented Sep 3, 2024

codecov bot commented Sep 4, 2024 •

edited

Loading

sophie-cluml commented Sep 4, 2024

sophie-cluml left a comment

sophie-cluml left a comment

sehkone Sep 6, 2024

BLYKIM Sep 8, 2024

sehkone Sep 6, 2024

sehkone Sep 6, 2024 •

edited

Loading

BLYKIM Sep 8, 2024

kimhanbeom commented Sep 9, 2024

		- Removed `unsafe` block in `write_run_tcpdump` while creating a temporary file.
		- Remove migration code less than `0.15.3`

Support command-line interface and update configuration API #796

Support command-line interface and update configuration API #796

Conversation

BLYKIM commented Aug 9, 2024 • edited Loading

kimhanbeom commented Aug 22, 2024 • edited Loading

sophie-cluml commented Sep 3, 2024

codecov bot commented Sep 4, 2024 • edited Loading

Codecov Report

sophie-cluml commented Sep 4, 2024

sophie-cluml left a comment

Choose a reason for hiding this comment

sophie-cluml left a comment

Choose a reason for hiding this comment

sehkone Sep 6, 2024

Choose a reason for hiding this comment

BLYKIM Sep 8, 2024

Choose a reason for hiding this comment

sehkone Sep 6, 2024

Choose a reason for hiding this comment

sehkone Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

BLYKIM Sep 8, 2024

Choose a reason for hiding this comment

kimhanbeom commented Sep 9, 2024

BLYKIM commented Aug 9, 2024 •

edited

Loading

kimhanbeom commented Aug 22, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading

sehkone Sep 6, 2024 •

edited

Loading