Change OpLogFilter::agent_id to be optional
#826
+672
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
==========================================
+ Coverage 76.98% 77.45% +0.46%
==========================================
Files 31 32 +1
Lines 24875 25362 +487
==========================================
+ Hits 19151 19643 +492
+ Misses 5724 5719 -5 ☔ View full report in Codecov by Sentry. |
henry0715-dev
force-pushed
the
henry/op-log-filter
branch
from
880ab3d
to
3c66f2e
Compare
henry0715-dev
force-pushed
the
henry/op-log-filter
branch
from
3c66f2e
to
d173f83
Compare
henry0715-dev
changed the title
OpLogFilter development directionOpLogFilter::agent_id to be optional
henry0715-dev
force-pushed
the
henry/op-log-filter
branch
2 times, most recently
from
6b211c0
to
be77ab4
Compare
henry0715-dev
force-pushed
the
henry/op-log-filter
branch
from
be77ab4
to
fe5bc59
Compare
kimhanbeom
reviewed
Nov 8, 2024
src/storage/migration.rs
Outdated
| @@ -216,6 +221,20 @@ fn migrate_0_19_to_0_21_0(db: &Database) -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[allow(clippy::too_many_lines)] | |||
There was a problem hiding this comment.
Could you please remove the #[allow(clippy::too_many_lines)]?
There was a problem hiding this comment.
The change has been completed.
Thank you.
Close #724 The RocksDB keys in the `oplog` are currently in the form agent_id-0-timestamp. This change modifies the keys to the form timestamp-0-sequence.
henry0715-dev
force-pushed
the
henry/op-log-filter
branch
from
fe5bc59
to
4bef708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #724
The RocksDB keys in the
oplogare currently in the form agent_id-0-timestamp. This change modifies the keys to the form timestamp-0-sequence.