Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorrect agent_key Format in AgentManager::update_config Call in applyNode #306

Closed
sophie-cluml opened this issue Sep 19, 2024 · 0 comments · Fixed by #307
Closed
Assignees
Labels
bug Something isn't working

Comments

@sophie-cluml
Copy link
Contributor

In the applyNode GraphQL API of review-web, the AgentManager::update_config function is being called with an incorrect format for the agent_key. The function update_config expects the agent_key to be in the format of:

// note: this is pseudo code
format!("{}@{}", agent.key, node.profile.unwrap().hostname)

However, the current implementation only uses agent.key, without the "@" sign and the "hostname". So we need to correct it.

@sophie-cluml sophie-cluml self-assigned this Sep 19, 2024
@sophie-cluml sophie-cluml added the bug Something isn't working label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant