Fix applyNode GraphQL API
#307
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
+ Coverage 67.06% 67.23% +0.17%
==========================================
Files 68 67 -1
Lines 12986 13142 +156
==========================================
+ Hits 8709 8836 +127
- Misses 4277 4306 +29 ☔ View full report in Codecov by Sentry. |
sophie-cluml
force-pushed
the
sophie/fix-apply-node
branch
3 times, most recently
from
df63ea4
to
0d5dee3
Compare
src/graphql/node/control.rs
Outdated
| } | ||
|
|
||
| Ok(ApplyNodeResponse { id, giganto_draft }) | ||
| } | ||
| } | ||
|
|
||
| fn format_agent_updates(node: &Node, target_agents: &NotificationTarget) -> String { |
There was a problem hiding this comment.
Could you explain why the log message includes all the content of the agents' configs and drafts? Some of these items are usually not visible to users, as the UI only shows what can be modified by them, but they become visible because of this message. If you're considering keeping a history of all the changes, I think it should be stored in the database rather than in log messages.
There was a problem hiding this comment.
This log was created to follow this guide
[Central server] logs the apply actions along with settings config, settings_draft draft, and the timestamp.
There was a problem hiding this comment.
It looks like I wrote the sentence. I apologize for the confusion caused by using the term "log" too loosely. When I used "log," I was thinking of its literal meaning—saving information—rather than in the syslog style. I intended that the specific method of storing could be decided based on the context. In this case, I don’t think the configs and drafts should be written to the log. As for how to handle them, I believe we can decide that later.
There was a problem hiding this comment.
Logs on config and draft are removed.
There was a problem hiding this comment.
Logs on
configanddraftare removed.
I still see them.
There was a problem hiding this comment.
I am sorry for the mistake. 🙇 It's done from my side now.
sophie-cluml
force-pushed
the
sophie/fix-apply-node
branch
from
0d5dee3
to
ae820c9
Compare
sophie-cluml
force-pushed
the
sophie/fix-apply-node
branch
from
ae820c9
to
fad1558
Compare
close #306
close #303