[WIP]Add updateTrustedDomain GraphQL API
#276
Conversation
|
The pr below should be merged first. |
| @@ -522,6 +522,9 @@ struct MockAgentManager {} | |||
| #[cfg(test)] | |||
| #[async_trait::async_trait] | |||
| impl AgentManager for MockAgentManager { | |||
| async fn broadcast_trusted_domains(&self) -> Result<(), anyhow::Error> { | |||
| Ok(()) | |||
There was a problem hiding this comment.
The broadcast_trusted_domains function in MockAgentManager has been modified to return Ok(()) for the purpose of executing test code
henry0715-dev
changed the title
updateTrustedDomain GraphQL APIupdateTrustedDomain GraphQL API
| new.name | ||
| }; | ||
|
|
||
| let agent_manager = ctx.data::<BoxedAgentManager>()?; |
There was a problem hiding this comment.
@sophie-cluml
It is necessary to determine whether it is important to use broadcasts.
It doesn't seem to be used in the source in review-web, but I think if it's an unnecessary source, it's better to remove it.
If there is an AgentManager implementation in the review, we will keep it as it is.
henry0715-dev
changed the title
updateTrustedDomain GraphQL APIupdateTrustedDomain GraphQL API
|
Could you rebase please? |
henry0715-dev
force-pushed
the
henry/modify-trusted-domains
branch
from
428be1a
to
63f58fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 61.58% 62.05% +0.47%
==========================================
Files 66 66
Lines 11630 11741 +111
==========================================
+ Hits 7162 7286 +124
+ Misses 4468 4455 -13 ☔ View full report in Codecov by Sentry. |
henry0715-dev
changed the title
updateTrustedDomain GraphQL APIupdateTrustedDomain GraphQL API
Closes #2