Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update babel to version 7 #22

Merged
merged 5 commits into from
Sep 16, 2018
Merged

update babel to version 7 #22

merged 5 commits into from
Sep 16, 2018

Conversation

achmadk
Copy link
Contributor

@achmadk achmadk commented Aug 30, 2018

Fixed #21 issue.

@coveralls
Copy link

Coverage Status

Coverage increased (+10.3%) to 100.0% when pulling 45283f2 on achmadk:master into a190d07 on aichbauer:master.

@coveralls
Copy link

coveralls commented Aug 30, 2018

Coverage Status

Coverage increased (+10.3%) to 100.0% when pulling f89a2ce on achmadk:master into a190d07 on aichbauer:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+10.3%) to 100.0% when pulling 45283f2 on achmadk:master into a190d07 on aichbauer:master.

Copy link
Owner

@aichbauer aichbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution... Looks good... Just one little thing.

Also when we want to merge this you need to drop the node version 4 in the travis file.

package.json Outdated
"babel-preset-env": "^1.2.1",
"babel-register": "^6.23.0",
"express": "^4.15.2",
"@babel/cli": "^7.0.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move the @babel/* dependencies to devdependencies except of @babel/runtime.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to move that @babel/* dependencies to devDependencies, but it will give an error when execute npm run test

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try moving these to devDependencies:

    "@babel/cli": "^7.0.0",
    "@babel/core": "^7.0.0",
    "@babel/plugin-transform-runtime": "^7.0.0",
    "@babel/preset-env": "^7.0.0",

and keep this as dependencies:

    "@babel/register": "^7.0.0",
    "@babel/runtime": "^7.0.0",

@aichbauer
Copy link
Owner

in the travis.yml you need to remove node version 4.

node_js:
  - 4
  - 6
  - 8
  - 10

to

node_js:
  - 6
  - 8
  - 10

@aichbauer aichbauer merged commit 4359f0b into aichbauer:master Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants