Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix readme links #1137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix readme links #1137

wants to merge 1 commit into from

Conversation

Armanio
Copy link

@Armanio Armanio commented Oct 2, 2024

Hi!
I fixed broken links in readme.md

Please describe the changes this PR makes and why it should be merged:

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Hi! 
I fixed broken links in readme.md
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 9:12am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 9:12am

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request updates two documentation links in the README.md file to fix broken URLs.

  • Updated links in README.md to point to correct Million.js documentation URLs
  • Changes are minor and do not affect codebase functionality, only improving documentation accuracy

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

@@ -52,7 +52,7 @@ npx million@latest

Once your down, just run your project and information should show up in your command line!
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: 'your' should be 'you're'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants