-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign header with logo, toggled info sections, etc. #751
Conversation
2f883a7
to
033412c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @edan-bainglass for the new header design. Very nice!
Few suggestions.
- Better to move the four-steps instruction in the
About
section to theGuide
section. Instead, you can add the the more general info, e.g., what the capability of the app (Bands, PDOS, XPS, IR/Raman, etc). - Regarding the
in-app guide
, we can discuss on detail implementaion . For this PR, could you hide theshow in-app guide
checkbox and related. - The custom CSS is kind of advanced topic, and would be very useful if you add some docs on it (e.g., the development guide).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
+ Coverage 68.16% 68.74% +0.57%
==========================================
Files 48 49 +1
Lines 4159 4236 +77
==========================================
+ Hits 2835 2912 +77
Misses 1324 1324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c35995b
to
9b36e8a
Compare
@edan-bainglass LMK once this is ready and I'll have a closer look (just a note that I am at the conference next week, so will get it no sooner than July 14th. |
cdf0bd7
to
2bb8bb8
Compare
1aeaee9
to
27051e2
Compare
a03050e
to
ed0a18f
Compare
ed0a18f
to
ad91e74
Compare
94bdd97
to
f20fd2a
Compare
f20fd2a
to
e40a437
Compare
3ff0d68
to
6a0465b
Compare
@danielhollas @superstar54 ready for review |
6a0465b
to
88deedd
Compare
88deedd
to
aef7ea3
Compare
@superstar54 your comments have all been addressed. Note that the last one regarding documenting CSS use - the PR introducing the CSS loader in AWB (aiidalab/aiidalab-widgets-base#624) adds docs there regarding CSS. Good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @edan-bainglass , thanks for the work! I added two mirror change requests. Ready to go after you fix them.
"metadata": {}, | ||
"outputs": [], | ||
"source": [ | ||
"controller.enable_toggles()" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only enable the toggler at the last? Is it possible to show the Guide
and About
when loading the main app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately no 😞 Loading the app is an event. Clicking on guide or about will add that event behind the loading event, i.e., it will only trigger after the app is done loading. This is bad UX, so I enable the buttons only once the app finishes loading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this means that the user can not do anything when loading the main app. I hope we can find some solution in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the app load faster 😅 Working on it
Co-authored-by: Xing Wang <[email protected]>
Based on #772
This PR replaces refactors the main notebook as follows:
AppWrapper
componentAppWrapper
component holds the banner, main, and footer componentsUse of CSS
The notebook now also loads two CSS stylesheets:
style
(style.css) - this was already used in the welcome pagecustom
(custom.css, compiled from custom.scss) - this is used for any custom styling we wish to add anywhere in the appThe general choice to use CSS is three-fold:
ipywidgets
styling APIipywidgets
only exposes a limited set of CSSCheckbox
widget is comprised of multiple HTML elementsipywidgets
does not provide a path for styling each