Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest the issue of setting multiple codes #415

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Manifest the issue of setting multiple codes #415

merged 4 commits into from
Dec 13, 2022

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Dec 12, 2022 •
edited
Loading

fixes #416

@unkcpz unkcpz marked this pull request as draft December 12, 2022 17:57
@unkcpz unkcpz force-pushed the set-multiple-code-from-quicksetup-of-same-commputer branch from 6b1befe to 20ea682 Compare December 12, 2022 18:13
@unkcpz unkcpz force-pushed the set-multiple-code-from-quicksetup-of-same-commputer branch from 990ce5a to 074fe5e Compare December 12, 2022 20:50
@unkcpz unkcpz marked this pull request as ready for review December 12, 2022 20:56
danielhollas
danielhollas previously approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this bug introduced during the migration, or was it there before?

Thanks for the new tests, I assume they would fail before the fix.

tests/test_notebooks.py Outdated Show resolved Hide resolved
@unkcpz @danielhollas
Update tests/test_notebooks.py
57ca9cb 
Co-authored-by: Daniel Hollas <[email protected]>
@unkcpz
Copy link
Member Author

unkcpz commented Dec 13, 2022

Was this bug introduced during the migration, or was it there before?

I think it will not raised previously, it was introduced by #410, the last commit I added to bring the _configure_computer back. In the previous case, if no SSH username was provided, the computer still get setup and configured but setting SSH again will not make it work afterward. Because the computer configuration need the SSH username updated.

Thanks for the new tests, I assume they would fail before the fix.

Yes, it would fail. This is the very positive side to have such a test framework. What a relief!

@unkcpz unkcpz merged commit 85c992b into master Dec 13, 2022
@unkcpz unkcpz deleted the set-multiple-code-from-quicksetup-of-same-commputer branch December 13, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhollas danielhollas danielhollas left review comments

@superstar54 superstar54 Awaiting requested review from superstar54

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The computer widget of code setup is not updated and will throw UUID not found error
2 participants
@unkcpz @danielhollas