Support and test with py3.11 #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #619 +/- ##
=======================================
Coverage 83.62% 83.62%
=======================================
Files 16 16
Lines 3517 3517
=======================================
Hits 2941 2941
Misses 576 576
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielhollas
commented
Jul 8, 2024
| # This is needed since SQLAlchemy 2.0, see | ||
| # https://github.com/aiidalab/aiidalab-widgets-base/issues/605 | ||
| 'ignore:Object of type .* not in session, .* operation along .* will not proceed:sqlalchemy.exc.SAWarning', | ||
| 'ignore::DeprecationWarning:bokeh.core.property.primitive', | ||
| 'ignore::DeprecationWarning:bokeh', |
There was a problem hiding this comment.
bokeh started throwing some new DeprecationWarning which is currently breaking this test suite, this fixes it. Going to merge this now.
|
This PR includes a DeprecationWarning ignore that is currently tripping up CI tests so going to merge this now. |
danielhollas
added a commit
that referenced
this pull request
Nov 19, 2024
- update scikit-learn dependency to support python 3.11
danielhollas
added a commit
that referenced
this pull request
Nov 19, 2024
- update scikit-learn dependency to support python 3.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support Python 3.11, we need to bump the scikit-learn dependency, and ignore some more DeprecationWarnings. Otherwise things seem to work.