-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: improve referencing to aiida-tutorials
#6288
Doc: improve referencing to aiida-tutorials
#6288
Conversation
aiida-tutorials
Hi @khsrali, thanks for creating the PR! To add some points here that came up during our discussion right now: Therefore, I propose to make everything consistent, i.e. naming the first panel the same as the first item in the top bar (e.g. "Introduction"), and have them both point to the same page. Further, moving the "Basic Tutorial" out of the "Introduction" and into its own page. We're still not sure where to best put the cheat sheet. Possibly as a separate panel on the landing page, as I proposed in issues #6287 and #6290 (though, we might not have enough space in the top bar to include eight items...). Alternatively, keeping just one "Tutorials" page, as @khsrali did in this PR, which then points to the "Basic" and "Advanced" Tutorials, where we could also add the cheat sheet. |
Thanks a lot @khsrali . I agree with @GeigerJ2 that it would be good to make the panel titles line up with the top bar navigation. I am not sure if we should rename the "Getting started" tile to "Introduction", though. As a new prospective user, typically I immediately search for something to get started. Seeing "Introduction" doesn't suggest to me immediately that I can find it there. It more seems like I would find a long-winded text like an academic paper. So I would be tempted to rename "Introduction" to "Getting started". Looking at the subsections of Regarding the design of the tutorials page: the advanced tutorials panel seems a bit off. It is now just a page that contains a link to |
Thank you @sphuber for noticing and your comments.
I agree with that too, I think it's a good idea.
I also think it's a good idea to put it on the main page; it wouldn't seem crowded to me. It could either replace the short introductory paragraph of AiiDA on top or go below the panels just above "How to cite".
You are actually right, that would have make more sense. But I thought maybe it would be nice to add a bit of explanation about where that link is going **--see below
Well the idea was simply to make Actually, I tried to give a short explanation with links, just as you say, but then it tuned into the advanced tutorials page **. If we completely remove the explanation and do not call it an "advanced" tutorial, then having |
I agree that having only the basic tutorial and then the link is not ideal. I think we can and probably should have more generic tutorials on the main documentation. That is why I would organize it as the |
Alright, then tutorials.rst part is already sort of done -- the tutorials page.
Many thanks for insights. To summarize, what I understood from @GeigerJ2 and @sphuber suggestions:
Please don't hesitate to add, if I forgot any. Otherwise, I'll turn this PR into a draft, implement these changes, and make a request again. |
Great summary @khsrali thanks a lot. Before you do anything, in order to prevent any unnecessary/double work, maybe we discuss this tomorrow with the rest of the team during the coding days. If they agree then you can go ahead and implement the changes, but would be good to have as much eyes on the suggestions for the docs as possible, and I want to prevent you have to keep changing things around. Would that work for you? |
Great, nice to let me know @sphuber ! it's best to discuss it first. |
I think having tutorial as a head navigator is a super great idea, I did participate in a talk about technical documentation authoring and it sells their rule https://diataxis.fr/. As I know the community like jupyter having some of their tool documentation move to follow this rule. I think we are more or less follow the rule. The tutorial is a pillar of the rule and something the new user usually want to find after they heard about the tool and want to get start.
Fully agree!
Remind me of a discussion https://aiida.discourse.group/t/section-what-is-aiida-is-not-easy-to-find/44 To be honest, I don't like the index page, it is gives very little information about what AiiDA is and how it is great. I think some content of "What is AiiDA" needs to go to the index page. I also didn't see the point that the introduction tab is simply a navigator link to more things. Moreover, the panel tabs (in the figure below) in the index page seems useless (if it is a "get start" it get user start, if it is a "Explanation" it explain things) and occupy too many space of the important index page. |
Thank you, @unkcpz for your comment. Very interesting! good to know.
As we discussed today in AiiDA-core wrap up, I'll take care of this and update the PR.
And with this comment of @sphuber we can certainly do a separate PR for that later on. |
Alright, changes noted have been applied. Main changes are:
I appreciate if @unkcpz if you can have look for review. |
Thanks @khsrali . The docs build is failing, which makes it more difficult to review the changes. Looking at the logs, there is at least this warning:
|
Thanks @sphuber, |
Hi @khsrali, thanks for taking care of this! To me, all looks good. The only suggestion I have would be to call it "Tutorial Archive", which sounds more like an ancient mystery box that I would like to click on and discover :D (otherwise, "Archived tutorials?) Just to mention it here, I have an open PR to update the current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @khsrali . Some final changes requested and then we can merge
docs/source/index.rst
Outdated
@@ -154,6 +154,7 @@ Welcome to AiiDA's documentation! | |||
:hidden: | |||
|
|||
intro/index | |||
intro/tutorial_page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are planning on adding multiple tutorials, I would actually take this opportunity to create the tutorials
directory and rename this page to tutorials/index.rst
. Then move the current intro/tutorial.md
to tutorials/basic.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, makes sense..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sphuber for your good suggestion. I applied this change.
However, tutorial without toctree feels very weird, especially now that it has its own directory.
please check now with the new commit, and let me know if you agree.
ok I was trying to squash commit, apparently it's useless when working on a fork.. |
The tutorials are moved to a separate page. A link is added to the `aiida-tutorials` repository as a source of additional tutorials. In the future, valuable tutorial information will be taken from there and directly integrated in the new tutorials page of the `aiida-core` docs. The "What is AiiDA" section is moved to the index page of the introduction.
It doesn't matter whether the branch is on a fork. I squashed the branch for you after updating it. I see that you have renamed your fork I typically set the original repo up as the remote
To squash the commits on your branch, I did the following
Now if you go Hopefully that helps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @khsrali , all good to go!
Thanks a lot @sphuber for merging and your very useful comment! |
Fixes #6287
Good morning everyone!
Following our discussion on issue #6287 about discoverability of
aiida-tutorials
I collected our ideas and made the following changes in documentation. I tried to keep changes minimal and inline with current formatting.aiida-tutorials
.Please feel free to join a review, and suggest your changes!
For simplicity, I took screenshot of the compilation and painted with red marker to show my changes:
To dos: