-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Python 3.13 #6600
Draft
agoscinski
wants to merge
9
commits into
aiidateam:main
Choose a base branch
from
agoscinski:py313-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Support for Python 3.13 #6600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpile py3.13 files
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6600 +/- ##
==========================================
+ Coverage 77.51% 77.87% +0.37%
==========================================
Files 560 567 +7
Lines 41444 42120 +676
==========================================
+ Hits 32120 32796 +676
Misses 9324 9324 ☔ View full report in Codecov by Sentry. |
agoscinski
added a commit
to agoscinski/aiida-core
that referenced
this pull request
Nov 4, 2024
Recstrict Python version ito strictly below 3.13 until we have resolved the dependency issues in PR aiidateam#6600.
This was referenced Nov 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for supporting python 3.13. Need to further debug dependencies
So far circus needs to be updated. Since the HEAD of the master branch seems to have fixed most issues on python 3.13, I wanted to test it and published a 0.19.0 version on test pypi from my fork https://github.com/agoscinski/circus
So far numpy needed an update to at least 1.26.2, versions before limited the python version to 3.12 (I am actually not sure how the requirements.txt got to 2.26.1 from the 1.21 in the pyproject.toml).
pandas does not offer binaries for python 3.13 until most recent version 2.2.3, and compiling it during installation fails.
Current issue, that need a bit investigation. I just did not have more time to look into it