-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Emit Daemon logs for pytest test run #6671
base: main
Are you sure you want to change the base?
Conversation
using watchdog to monitoring the daemon log in tmp pytest folder and emit in the debug logger level.
The implementation is a bit hacky, since it open a thread to run watchdog to monitoring the file and emit content to log. |
f.seek(self._pos) | ||
new_output = f.read() | ||
if new_output: | ||
logger.debug(new_output) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I should not use logger here since the content of the log file is in log format.
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6671 +/- ##
==========================================
+ Coverage 77.94% 77.95% +0.02%
==========================================
Files 563 563
Lines 41761 41796 +35
==========================================
+ Hits 32545 32579 +34
- Misses 9216 9217 +1 ☔ View full report in Codecov by Sentry. |
using watchdog to monitoring the daemon log in tmp pytest folder and emit in the debug logger level.
(I think there should be a better way to do this by not using circus to start the daemon in pytest)
To get the log in the daemon.log file, run test with: