Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to be compatible with pyfirecreset v2.6.0 #36

Merged
merged 39 commits into from
Jul 30, 2024
Merged

Upgrade to be compatible with pyfirecreset v2.6.0 #36

merged 39 commits into from
Jul 30, 2024

Commits on Jun 17, 2024

  1. - Some TODO's are done, wherever relavant, I implemented changes to `… 

    …aiida-core`.

- Refactor FirecrestScheduler to handle pagination for retrieving active jobs
- dynamic_info() is added to retrieve machine information without user input.
- put & get & copy passed manual test.
- Added `dereference` option wherever relevant
- Added new tests. The old tests, although more suffesticated is harder to debug. New test focuses only on aiida-firecrest by mocking pyfirecrest only, not the server.
    @khsrali
    khsrali committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2113752 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. added tests for transport:get

    @khsrali
    khsrali committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    9e3d30d View commit details
    Browse the repository at this point in the history

  2. new tests moved as a subdirectory of the main tests

    @khsrali
    khsrali committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    56ff1ee View commit details
    Browse the repository at this point in the history

  3. update readme.md

    @khsrali
    khsrali committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    83a4eb8 View commit details
    Browse the repository at this point in the history

  4. added test_transport::put*

    @khsrali
    khsrali committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4052ae7 View commit details
    Browse the repository at this point in the history

  5. added test_transport::copy*

    @khsrali
    khsrali committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a4588f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. added test_scheduler

    @khsrali
    khsrali committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c9ab8a6 View commit details
    Browse the repository at this point in the history

  2. Applied ruff and mypy

    @khsrali
    khsrali committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f452999 View commit details
    Browse the repository at this point in the history

  3. Readme updated

    @khsrali
    khsrali committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    6304a75 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. _copy_to moved from path.py directly to interface + updated aiida-c… 

    …ore dependency
    @khsrali
    khsrali committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    202e14f View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. property _is_open added to skip AttributeError raised by aiida-core

    @khsrali
    khsrali committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3c3773f View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. bug fix: when get_job() is retiereving a completed job 

    bug fix: iglob() is sending relative path to listdir()
compatibility with new version of firecrest: extract() and compress()  will take care of submission if needed
    @khsrali
    khsrali committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    96fe286 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Update FirecREST token url

    @khsrali
    khsrali authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    0d45d6b View commit details
    Browse the repository at this point in the history

  2. Update README.md with correct Token URI (#1)

    @mikibonacci
    mikibonacci authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    00c4be9 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. added support for glob patterns in

    @khsrali
    khsrali committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f7519a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. Enforce str for super method has_magic()

    @khsrali
    khsrali committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    8ebe531 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Rico Haeuselmann <[email protected]>
    @khsrali @DropD
    khsrali and DropD authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e493fc5 View commit details
    Browse the repository at this point in the history

  2. Updated tests

    @khsrali
    khsrali committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    c83a893 View commit details
    Browse the repository at this point in the history

  3. temporarly turnned off Codecov

    @khsrali
    khsrali committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b245639 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @khsrali
    khsrali authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    be9b52f View commit details
    Browse the repository at this point in the history

  5. review applied

    @khsrali
    khsrali committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f792b45 View commit details
    Browse the repository at this point in the history

  6. some info added in changelog

    @khsrali
    khsrali committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a238dad View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Alexander Goscinski <[email protected]>
    @khsrali @agoscinski
    khsrali and agoscinski authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    689ef55 View commit details
    Browse the repository at this point in the history

  2. test_calculation.py retrieved

    @khsrali
    khsrali committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    70450fe View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Alexander Goscinski <[email protected]>
    @khsrali @agoscinski
    khsrali and agoscinski authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    d2ccb9e View commit details
    Browse the repository at this point in the history

  2. appied review

    @khsrali
    khsrali committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    64838a6 View commit details
    Browse the repository at this point in the history

  3. added a functionality to check the api version

    @khsrali
    khsrali committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    08482c8 View commit details
    Browse the repository at this point in the history

  4. updated tests

    @khsrali
    khsrali committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f866a6f View commit details
    Browse the repository at this point in the history

  5. Bringing back the option to run firecrest with a config with a real s… 

    …erver (#2)

* Bringing back the option to run firecrest with a config with a real server

---------

Co-authored-by: Ali Khosravi <[email protected]>
    @agoscinski @khsrali
    agoscinski and khsrali authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6c7101c View commit details
    Browse the repository at this point in the history

  6. fix tests

    @khsrali
    khsrali committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    364e3a4 View commit details
    Browse the repository at this point in the history

  7. fixtests.patch removed

    @khsrali
    khsrali committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    5994285 View commit details
    Browse the repository at this point in the history

  8. __future__ added

    @khsrali
    khsrali committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6323547 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Final updates on tests, now functional with server test. 

    CI to be added in a separate PR.
    @khsrali
    khsrali committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    7cc3e97 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Alexander Goscinski <[email protected]>
    @khsrali @agoscinski
    khsrali and agoscinski authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1b38515 View commit details
    Browse the repository at this point in the history

  2. Server github action should skip for now

    @khsrali
    khsrali committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    28d481c View commit details
    Browse the repository at this point in the history

  3. check if codecov works

    @khsrali
    khsrali committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d143add View commit details
    Browse the repository at this point in the history

  4. Readme updated.

    @khsrali
    khsrali committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6742b6c View commit details
    Browse the repository at this point in the history

  5. Applied changes from final review

    @khsrali
    khsrali committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e229561 View commit details
    Browse the repository at this point in the history

  6. change from random to itertools

    @khsrali
    khsrali committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7254af5 View commit details
    Browse the repository at this point in the history