Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recent release sort option to the website #256

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Add recent release sort option to the website #256

merged 4 commits into from
Aug 17, 2023

Conversation

AhmedBasem20
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-08-17 12:22 UTC

unkcpz
unkcpz requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I resolve the conflict after #255. I think it is all good to go!
Just a nitpick on the comments of the code, I hope it will make the sorting order more clear, do you agree?

aiida-registry-app/src/Components/MainIndex.jsx Outdated Show resolved Hide resolved
aiida-registry-app/src/Components/MainIndex.jsx Outdated Show resolved Hide resolved
aiida-registry-app/src/Components/MainIndex.jsx Outdated Show resolved Hide resolved
@unkcpz
Copy link
Member

unkcpz commented Aug 17, 2023

I'll merge gsoc to main after this one.

@AhmedBasem20
Copy link
Collaborator Author

Thanks @unkcpz I corrected the comments you mentioned, and I also moved the code to a separate function sortByRelease(). And in useEffect I replaced the call to sortByCommits() with a call to handleSort().
This way if we want to change the default sort option at any time we just change that line:

aiida-registry/aiida-registry-app/src/Components/MainIndex.jsx

Line 19 in 82ab0f7

const [sortOption, setSortOption] = useState('commits'); //Available options: 'commits', 'release', and 'alpha'.

unkcpz
unkcpz approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear, thanks!

@unkcpz unkcpz merged commit 106877f into gsoc Aug 17, 2023
10 checks passed
@unkcpz unkcpz deleted the release-sort-frontend branch August 17, 2023 11:45
unkcpz pushed a commit that referenced this pull request Aug 17, 2023
@AhmedBasem20 @unkcpz
Add recent release sort option to the website (#256)
6e88ce7 
In this commit, we add the release sort option to the frontend so the plugins can ranking by the latest released date.

---------
Co-authored-by: Jusong Yu <[email protected]>
unkcpz pushed a commit that referenced this pull request Aug 17, 2023
@AhmedBasem20 @unkcpz
Add recent release sort option to the website (#256)
b8a1e7a 
In this commit, we add the release sort option to the frontend so the plugins can ranking by the latest released date.

---------
Co-authored-by: Jusong Yu <[email protected]>
unkcpz pushed a commit that referenced this pull request Aug 17, 2023
@AhmedBasem20 @unkcpz
Add recent release sort option to the website (#256)
553ec72 
In this commit, we add the release sort option to the frontend so the plugins can ranking by the latest released date.

---------
Co-authored-by: Jusong Yu <[email protected]>
unkcpz pushed a commit that referenced this pull request Aug 17, 2023
@AhmedBasem20 @unkcpz
Add recent release sort option to the website (#256)
8afaa66 
In this commit, we add the release sort option to the frontend so the plugins can ranking by the latest released date.

---------
Co-authored-by: Jusong Yu <[email protected]>
unkcpz pushed a commit that referenced this pull request Aug 17, 2023
@AhmedBasem20 @unkcpz
Add recent release sort option to the website (#256)
519743a 
In this commit, we add the release sort option to the frontend so the plugins can ranking by the latest released date.

---------
Co-authored-by: Jusong Yu <[email protected]>
unkcpz pushed a commit that referenced this pull request Aug 17, 2023
@AhmedBasem20 @unkcpz
Add recent release sort option to the website (#256)
0646352 
In this commit, we add the release sort option to the frontend so the plugins can ranking by the latest released date.

---------
Co-authored-by: Jusong Yu <[email protected]>
unkcpz pushed a commit that referenced this pull request Aug 17, 2023
@AhmedBasem20 @unkcpz
Add recent release sort option to the website (#256)
5f144b0 
In this commit, we add the release sort option to the frontend so the plugins can ranking by the latest released date.

---------
Co-authored-by: Jusong Yu <[email protected]>
unkcpz pushed a commit that referenced this pull request Aug 17, 2023
@AhmedBasem20 @unkcpz
Add recent release sort option to the website (#256)
97620d6 
In this commit, we add the release sort option to the frontend so the plugins can ranking by the latest released date.

---------
Co-authored-by: Jusong Yu <[email protected]>
unkcpz pushed a commit that referenced this pull request Aug 17, 2023
@AhmedBasem20 @unkcpz
Add recent release sort option to the website (#256)
953c268 
In this commit, we add the release sort option to the frontend so the plugins can ranking by the latest released date.

---------
Co-authored-by: Jusong Yu <[email protected]>
unkcpz pushed a commit that referenced this pull request Aug 18, 2023
@AhmedBasem20 @unkcpz
Add recent release sort option to the website (#256)
cb193d0 
In this commit, we add the release sort option to the frontend so the plugins can ranking by the latest released date.

---------
Co-authored-by: Jusong Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unkcpz unkcpz unkcpz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedBasem20 @unkcpz