Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins.yaml with aiida-fans #340

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

ethan-shanahan
Copy link
Contributor

Added the aiida-fans plugin specification to the plugins.yaml file.

Copy link

github-actions bot commented Nov 18, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://aiidateam.github.io/aiida-registry/pr-preview/pr-340/
on branch gh-pages at 2024-11-26 21:00 UTC

@unkcpz
Copy link
Member

unkcpz commented Nov 26, 2024

Thanks @ethan-shanahan, could you add some description for the plugin and the plans in the README.md?

@ethan-shanahan
Copy link
Contributor Author

Thanks for looking into this. I've updated the README.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ethan-shanahan for adding the README. It seems the link of the FANS repository is broken? (I guess it is this one? https://github.com/DataAnalyticsEngineering/FANS)

@ethan-shanahan
Copy link
Contributor Author

Yeah sorry about that @unkcpz. The links should be fixed now.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@unkcpz unkcpz merged commit c71c042 into aiidateam:master Nov 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants