-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Publish workflow (PyPI) #83
base: main
Are you sure you want to change the base?
Conversation
6fcde1c
to
25d2bb8
Compare
@@ -1,3 +1 @@ | |||
"""A pytest plugin for testing AiiDA plugins.""" | |||
|
|||
__version__ = '0.1.0.dev1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the __version__
attribute is very useful for this package and it complicates package management so I am removing it. Dissenters will be pointed to a lengthy discussion thread on CPython forum full of people arguing about this. :-D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please point me to the lengthy discussion, would be a nice read material after dinner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyproject.toml
Outdated
@@ -7,8 +7,8 @@ name = "aiida_test_cache" | |||
|
|||
[project] | |||
name = "aiida-test-cache" | |||
version = "0.0.1a0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to first publish a version 0.0.1
which should be fully backwards compatible and can be used by existing users.
@unkcpz @agoscinski can you take a look? Once I have a green light on this workflow I'll add instructions for maintainers into docs. |
@unkcpz @agoscinski Also can you please send me your user names on PyPI so that I can add you as maintainers of the |
This adds a GHA workflow for publishing to PyPI.
This uses the relatively new Trusted Publisher authentication mechanism, which does not require storing a secret token in repository settings (we should consider migrating aiida-core to this as well imo).
The workflow itself is triggered when a tag is created (Typically by creating a release on GitHub UI). Additionally, one can test the release by publishing to TestPyPI by adding a
test-release
label to a PR.I have used this workflow in another (non-AiiDA) repository and it's been working well.
Closes #72