Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate release 0.7.3.1 #1263

Merged
merged 8 commits into from
Mar 5, 2024
Merged

Intermediate release 0.7.3.1 #1263

merged 8 commits into from
Mar 5, 2024

Conversation

nicl-nno
Copy link
Collaborator

@nicl-nno nicl-nno commented Mar 5, 2024

  • Minor fixes
  • Modified int tests

Copy link

docu-mentor bot commented Mar 5, 2024

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

@pep8speaks
Copy link

pep8speaks commented Mar 5, 2024

Hello @nicl-nno! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-03-05 14:58:53 UTC

Copy link
Contributor

github-actions bot commented Mar 5, 2024

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.85%. Comparing base (3c2c028) to head (780900a).

Files Patch % Lines
fedot/core/caching/base_cache_db.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1263      +/-   ##
==========================================
- Coverage   79.85%   79.85%   -0.01%     
==========================================
  Files         146      146              
  Lines       10028    10030       +2     
==========================================
+ Hits         8008     8009       +1     
- Misses       2020     2021       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valer1435
Copy link
Collaborator

Только хотел залить свои фиксы интеграционников)

Copy link
Collaborator

@valer1435 valer1435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По поводу удаления последнего assert - мне тоже кажется он лишним. Учитывая кол-во обученных пайплайнов, логично, что дошли до сходимости и там может не быть разницы из-за сидов

@nicl-nno
Copy link
Collaborator Author

nicl-nno commented Mar 5, 2024

/fix-pep8

@nicl-nno nicl-nno merged commit fd21c70 into master Mar 5, 2024
7 checks passed
@nicl-nno nicl-nno deleted the 074 branch September 4, 2024 10:21
@nicl-nno nicl-nno restored the 074 branch September 4, 2024 10:22
@nicl-nno nicl-nno deleted the 074 branch September 4, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants