Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NaNs containing data on fit stage for fast_ica #1295

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

Lopa10ko
Copy link
Collaborator

@Lopa10ko Lopa10ko commented May 28, 2024

This is a 🐛 bug fix.

This PR aims to fix the ValueError: array must not contain infs or NaNs for pipelines with fast_ica node.

  • Add default PCA fallback on FastICA error (640a43c)
  • Perform local integration testing to ensure a thorough check
  • Perform integration testing on Github Actions

Context and reproducibility steps:
closes #1293

@Lopa10ko Lopa10ko self-assigned this May 28, 2024
Copy link

docu-mentor bot commented May 28, 2024

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

Copy link
Contributor

github-actions bot commented May 28, 2024

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

Copy link
Collaborator

@nicl-nno nicl-nno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да в целом можно и так, раз помогает, надо только это пометить как воркэраунд.

@Lopa10ko Lopa10ko merged commit d2a6785 into master May 29, 2024
6 checks passed
@Lopa10ko Lopa10ko deleted the fix-fastica-nans branch May 31, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NaN-filled fit stage of topo+ica pipelines
2 participants