-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support up-to-date botocore
#1057
Conversation
072224d
to
20a7b31
Compare
20a7b31
to
54181aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
+ Coverage 86.39% 86.46% +0.06%
==========================================
Files 60 60
Lines 5807 5814 +7
==========================================
+ Hits 5017 5027 +10
+ Misses 790 787 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ef693f0
to
7b70394
Compare
@thehesiod: This PR adds support for a whole bunch of new and updated AWS services that are released during re:Invent 2023. I suggest to do a release soon to maintain feature parity.
|
that's so awesome you added link to diff. We need to add that to the template in the checklist with example |
looks great, thanks! |
@@ -7,15 +7,15 @@ | |||
# NOTE: When updating botocore make sure to update awscli/boto3 versions below | |||
install_requires = [ | |||
# pegged to also match items in `extras_require` | |||
'botocore>=1.31.16,<1.31.71', | |||
'botocore>=1.32.4,<1.33.2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this in the review, it's doubtful this aiobotocore is compatible across these versions given it required changes to match the latest botocore
Description of Change
This PR intends to improve general compatibility of
aiobotocore
within the Python ecosystem by bumping the dependency specification ofbotocore
, as well asboto3
andawscli
.Assumptions
Upstream diff contains several minor changes that affect this codebase.
Checklist for All Submissions
args.py
,client.py
, andutils.py
turned out to be trivial.Checklist when updating botocore and/or aiohttp versions