Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AttributeError for Elasticsearch>2.0.0,<3.0.0 #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix AttributeError for Elasticsearch>2.0.0,<3.0.0 #197

wants to merge 1 commit into from

Commits on Nov 11, 2019

  1. Fix AttributeError for Elasticsearch>2.0.0,<3.0.0 

    AIOHttpConnection takes use_ssl argument and passes one to the parent's __init__.

Then self.use_ssl gets used instead of use_ssl here
https://github.com/aio-libs/aioelasticsearch/blob/master/aioelasticsearch/connection.py#L52

It works for the latest elasticsearch-py versions, however, it doesn't work with >2.0.0, b/c there's no self.use_ssl = use_ssl there.
    @artemknd
    artemknd authored Nov 11, 2019
    Configuration menu
    Copy the full SHA
    baa68ef View commit details
    Browse the repository at this point in the history