Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove loop argument from asyncio calls #311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janLo
Copy link

@janLo janLo commented Jan 17, 2022

The loop parameter was removed in python 3.10 and causes a TypeError there:

   File "/usr/local/lib/python3.10/site-packages/aioelasticsearch/__init__.py", line 33, in __init__                                                                                                                                                                                                                                                        
     super().__init__(hosts, transport_class=transport_class, **kwargs)                                                                                                                                                                                                                                                                                        
   File "/usr/local/lib/python3.10/site-packages/elasticsearch/client/__init__.py", line 205, in __init__                                                                                                                                                                                                                                                         
     self.transport = transport_class(_normalize_hosts(hosts), **kwargs)                                                                                                                                                                                                                                                                                       
  File "/usr/local/lib/python3.10/site-packages/aioelasticsearch/transport.py", line 74, in __init__                                                                                                                                                                                                                                                       
     self._connection_pool_lock = asyncio.Lock(loop=self.loop)                                                                                                                                                                                                                                                                                                 
  File "/usr/local/lib/python3.10/asyncio/locks.py", line 77, in __init__                                                                                                                                                                                                                                                                                       
    super().__init__(loop=loop)                                                                                                                                                                                                                                                                                                                                
  File "/usr/local/lib/python3.10/asyncio/mixins.py", line 17, in __init__                                                                                                                                                                                                                                                                                      
    raise TypeError(                                                                                                                                                                                                                                                                                                                                         TypeError: As of 3.10, the *loop* parameter was removed from Lock() since it is no longer necessary 

Are there changes in behavior for the user?

It might not work as expected anymore if the user tries to use a loop that is not the defauult loop for the current thread - but it seems that this is not supported by python anymore anyway.

Related issue number

None to my knowledge.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

The loop parameter was removed in python 3.10 and causes a TypeError there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant