do not output . and .. in client.list(*, recursive=True) as these create symlink loop on all ftp servers with UNIX systems
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all ftp servers with unix systems
CrafterKolyan
commented
Jul 11, 2023
CrafterKolyan
commented
Jul 11, 2023
pohmelie
reviewed
Jul 12, 2023
pohmelie
reviewed
Jul 12, 2023
Co-authored-by: Nikita Melentev <[email protected]>
|
Please rerun workflow |
pohmelie
changed the title
. and .. in client.list(*, recursive=True) as these create symlink loop on all ftp servers with UNIX systems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix a bug when you use
client.list(path, recursive=True)and never get out of it due to symlink loop with.and...Are there changes in behavior for the user?
Yes, if users had files
.and..previously in the output ofclient.list(path)then they won't see them now.Also
client.list(path, recursive=True)will now work for UNIX systemsTesting
Tested these changes on FTP server with UNIX filesystem
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.