Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only use AI_ADDRCONFIG when supported by getaddrinfo #10542

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maxbachmann
Copy link

The fallback implementation for getaddrinfo in CPython doesn't support AI_ADDRCONFIG and currently fails with a bad flags error. This changes the implementation to only set the flag if it's part of AI_MASK. Since AI_MASK isn't necessarily available either this has to be checked first.

E.g. the fallback implementation for getaddrinfo in CPython doesn't support it and currently fails with a bad flags error
@maxbachmann maxbachmann requested a review from asvetlov as a code owner March 12, 2025 11:47
Copy link

codspeed-hq bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #10542 will not alter performance

Comparing maxbachmann:patch-1 (ade8683) with master (4399a6c)

Summary

✅ 46 untouched benchmarks

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (4399a6c) to head (ade8683).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10542   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files         122      122           
  Lines       37230    37233    +3     
  Branches     2064     2065    +1     
=======================================
+ Hits        36748    36751    +3     
  Misses        335      335           
  Partials      147      147           
Flag Coverage Δ
CI-GHA 98.58% <66.66%> (-0.01%) ⬇️
OS-Linux 98.24% <33.33%> (-0.01%) ⬇️
OS-Windows 96.17% <33.33%> (-0.02%) ⬇️
OS-macOS 97.35% <66.66%> (-0.01%) ⬇️
Py-3.10.11 97.26% <66.66%> (-0.01%) ⬇️
Py-3.10.16 97.80% <33.33%> (-0.01%) ⬇️
Py-3.11.11 97.89% <33.33%> (-0.02%) ⬇️
Py-3.11.9 97.34% <66.66%> (-0.02%) ⬇️
Py-3.12.9 98.35% <66.66%> (+<0.01%) ⬆️
Py-3.13.2 98.33% <66.66%> (-0.01%) ⬇️
Py-3.9.13 97.14% <66.66%> (+<0.01%) ⬆️
Py-3.9.21 97.67% <33.33%> (-0.01%) ⬇️
Py-pypy7.3.16 87.05% <33.33%> (+0.33%) ⬆️
VM-macos 97.35% <66.66%> (-0.01%) ⬇️
VM-ubuntu 98.24% <33.33%> (-0.01%) ⬇️
VM-windows 96.17% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant