-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove chardet/charset-normalizer. #7589
Remove chardet/charset-normalizer. #7589
Conversation
…ntSession parameter. (aio-libs#7561) Co-authored-by: Sam Bull <[email protected]> (cherry picked from commit 6755796)
@Dreamsorcerer Here's that PR we discussed. Looks like this isn't quite ready. The code and tests should be correct, but I haven't got the docs updated. |
Codecov Report
@@ Coverage Diff @@
## 3.8 #7589 +/- ##
==========================================
- Coverage 97.38% 97.37% -0.02%
==========================================
Files 107 107
Lines 31056 31049 -7
Branches 3937 3940 +3
==========================================
- Hits 30243 30233 -10
- Misses 608 610 +2
- Partials 205 206 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
e530e2a
to
2f43204
Compare
OK, looks like it's ready. That should auto-merge, then we just need the final PR. |
Add fallback_charset_resolver ClientSession parameter. (#7561)
Co-authored-by: Sam Bull [email protected]
(cherry picked from commit 6755796)